Redundant?

[Nean]

Code:

Private Sub chkServerLog_Click()
    ' if its not 0, then its true
    If Not chkServerLog.Value Then
        ServerLog = True
    Else
        ServerLog = False
    End If
End Sub

Wouldn't it be simpler to just see if it's checked, rather than toggle a boolean when it's checked? Rather than seeing if the ServerLog = True or false, why not just have it as

Code:

If frmserver.chkserverlog.value = 1 Then
DoCode

Am I missing something obvious?

[Matt]

It's less code in the long run, if you think about it. I'd rather just check a single boolean (I prefer to use a byte..) than have to type all that out each time.

[Labmonkey]

Less code in vb6 doesn't actually mean its faster. But really, it will make such an insignificant difference. Just ignore it.

[Matt]

Who said anything about speed? I'm just lazy. Lol.

[Nean]

Hmmm. Alright, just trying to learn good habits for programming. Figured, I'd ask you guys. Thanks!

[GIAKEN]

You know to reduce that to a single line?

Code:

Private Sub chkServerLog_Click()
    ' if its not 0, then its true
    ServerLog = Not chkServerLog.Value
End Sub