29-05-2012, 04:46 PM
Matt Wrote:Jacob Wrote:Whoever wrote this just made EVERYTHING public static, this is absolutely horrible coding practice. I can guess most of the people that would use it don't care about OOP and other more advanced techniques, but jesus this code is bad.
It can always be fixed. It's a good base, though.
William Wrote:The structs can be turned into classes without too much difficulty. Not everything needs to be perfect for something to be good. It's still a big step up from miragesource.
Gonna disagree with both of you. It's exactly the same as mirage source, horrible coding examples for people to learn from.
Saying it needs to be perfect to start is wrong, but the codebase should be written using proper coding techniques. There seems to be zero point in moving it from VB6 to C# with that example of drool he's made. It can't be fixed without rewriting the whole thing.