+- Mirage Source (https://mirage-engine.uk/forums)
+-- Forum: Mirage Source (Nostalgia) (https://mirage-engine.uk/forums/forumdisplay.php?fid=61)
+--- Forum: Archive (2006-2011) (https://mirage-engine.uk/forums/forumdisplay.php?fid=18)
+---- Forum: Resources (https://mirage-engine.uk/forums/forumdisplay.php?fid=49)
+---- Thread: Remove Code (/showthread.php?tid=810)
Remove Code - William - 09-03-2007
AddChar
Find and Remove:
Code:
' Prevent being me
If LCase(Trim(Name)) = "consty" Then
Call AlertMsg(Index, "Lets get one thing straight, you are not me, ok? :)")
Exit Sub
End IfWeather
This is not so much of a bug fix, but it's useless code unless you add a weather system to your game. So do not remove this if you have or going to add a weather system.
Server Side
Find and Remove:
Code:
'WeatherSeconds = WeatherSeconds + 1
'TimeSeconds = TimeSeconds + 1
' Lets change the weather if its time to
If WeatherSeconds >= 60 Then
i = Int(Rnd * 3)
If i GameWeather Then
GameWeather = i
Call SendWeatherToAll
End If
WeatherSeconds = 0
End If
' Check if we need to switch from day to night or night to day
If TimeSeconds >= 60 Then
If GameTime = TIME_DAY Then
GameTime = TIME_NIGHT
Else
GameTime = TIME_DAY
End If
Call SendTimeToAll
TimeSeconds = 0
End IfCode:
' Used for weather effects
Public GameWeather As Long
Public WeatherSeconds As Long
Public GameTime As Long
Public TimeSeconds As LongCode:
' Init atmosphere
GameWeather = WEATHER_NONE
WeatherSeconds = 0
GameTime = TIME_DAY
TimeSeconds = 0Code:
' Weather constants
Public Const WEATHER_NONE = 0
Public Const WEATHER_RAINING = 1
Public Const WEATHER_SNOWING = 2
' Time constants
Public Const TIME_DAY = 0
Public Const TIME_NIGHT = 1Code:
Sub SendWeatherTo(ByVal Index As Long)
Dim Packet As String
Packet = "WEATHER" & SEP_CHAR & GameWeather & SEP_CHAR & END_CHAR
Call SendDataTo(Index, Packet)
End Sub
Sub SendWeatherToAll()
Dim i As Long
For i = 1 To MAX_PLAYERS
If IsPlaying(i) Then
Call SendWeatherTo(i)
End If
Next i
End Sub
Sub SendTimeTo(ByVal Index As Long)
Dim Packet As String
Packet = "TIME" & SEP_CHAR & GameTime & SEP_CHAR & END_CHAR
Call SendDataTo(Index, Packet)
End Sub
Sub SendTimeToAll()
Dim i As Long
For i = 1 To MAX_PLAYERS
If IsPlaying(i) Then
Call SendTimeTo(i)
End If
Next i
End SubClient Side
Find and Remove:
Code:
' Weather constants
Public Const WEATHER_NONE = 0
Public Const WEATHER_RAINING = 1
Public Const WEATHER_SNOWING = 2
' Time constants
Public Const TIME_DAY = 0
Public Const TIME_NIGHT = 1Code:
' Used for atmosphere
Public GameWeather As Long
Public GameTime As LongCode:
' ::::::::::::::::::::
' :: Weather packet ::
' ::::::::::::::::::::
If (LCase(Parse(0)) = "weather") Then
GameWeather = Val(Parse(1))
End If
' :::::::::::::::::
' :: Time packet ::
' :::::::::::::::::
If (LCase(Parse(0)) = "time") Then
GameTime = Val(Parse(1))
End If- Coke - 09-03-2007
Just a suggestion, better to comment them out then they dont affect your program anymore but are there for the future :wink:.
- William - 09-03-2007
Fox Wrote:Just a suggestion, better to comment them out then they dont affect your program anymore but are there for the future :wink:.Bad idea to keep comenting everything, its easy to get the code back now when it is here
- Coke - 09-03-2007
Really? I thought comments were not seen at runtime? o.0
- William - 09-03-2007
Fox Wrote:Really? I thought comments were not seen at runtime? o.0It is not there at runtime. But the thing is the programming style, it's bad idea to comment out everything, it will just mess things up. The same goes for indents.
- Coke - 09-03-2007
So its not really bad... just if your hyper neat like you ^_^
- William - 09-03-2007
Fox Wrote:So its not really bad... just if your hyper neat like you ^_^Doesn't comments make the .exe bigger?
- William - 09-03-2007
I remember there being a discussion about this before. There was no real final answer I think. It might not effect much. We all program in different ways. Myself only have those things in the game that is being used. Other stuffs just take up place.
- Robin - 09-03-2007
Why would comments be compiled into native code?
They are there IDE but on in the .exe
Of course, you could be a little swot and go paste 1000 lines of commented code and 1000 lines of uncommented and see if they change the .exe
- William - 09-03-2007
Comments do not effect the size of the exe. So comment it if you wish.
- Robin - 09-03-2007
but you just said they did ;_;
- William - 09-03-2007
Kite, I wrote:
William Wrote:I remember there being a discussion about this before. There was no real final answer I think. It might not effect much.I was not sure if comments effected it something. But now I know that they dont.
- Coke - 09-03-2007
Comments 1 William 0
haha only joking
Its good to know that it isnt in the .exe, useful thread even if its just for that
- Obsidian - 09-03-2007
William Wrote:The same goes for indents.
Dammit man... i hate it sooooo much when people don't properly nest code (in ANY language)... i should probably just start a topic about it in rants/raves, but how people can go through and code without nesting just blows me away. I can't function properly in different IDEs with improperly nested code. (Not pointed at you william, you just brought it up, so i thought i'd rant about it)
- William - 09-03-2007
What are you talking about Obsidian? There has been no discussion about nesting here..
We discussed about commenting not affecting the exe size.. ??
- Obsidian - 09-03-2007
You brought up 'indenting'. Indenting = Nesting
- Xlithan - 10-03-2007
just use CodeFixer. It will comment out anything that's not used or called, and will save a few bytes when compiling
- William - 10-03-2007
Obsidian Wrote:You brought up 'indenting'. Indenting = NestingYeah guess I did
Anyway, my indents might be too big,.
- ShadowLife - 10-03-2007
I keep it simple, Tab.
Makes lines a bit long at times, but I like having a homogenous structure.
- Robin - 10-03-2007
ShadowLife Wrote:I keep it simple, Tab.
Makes lines a bit long at times, but I like having a homogenous structure.
Heheh. Homo. Anyway, just keep it as two space indent. Makes it look a lot neater.