pingu Wrote:William needs to learn to indent a bit better.

The only things that should be without indents is the sub declaration and the "Dim"s. After that, you start out with one indent and add another each time an "If", "For", "While", "With", or "Select" is used. you obviously remove one when you end each one.

I don't know if what you posted it your actual style or something quick you did, so ignore this post if you normally don't format like that.

William Wrote:

pingu Wrote:William needs to learn to indent a bit better.

The only things that should be without indents is the sub declaration and the "Dim"s. After that, you start out with one indent and add another each time an "If", "For", "While", "With", or "Select" is used. you obviously remove one when you end each one.

I don't know if what you posted it your actual style or something quick you did, so ignore this post if you normally don't format like that.

Hehe, it's nice that you try to teach me. But how I program isn't really anybodies business. And sure, I havnt taken classes in how to indent. But the way I code, is the way I want, the way I think it looks easiest

Quote:

Code:

Sub SendIndexWornEquipmentFromMap(ByVal Index As Long)
Dim Packet As String
Dim i As Long
Dim Armor As Long
Dim Helmet As Long
Dim Shield As Long
Dim Weapon As Long

For i = 1 To MAX_PLAYERS
    If IsPlaying(i) = True Then
        If GetPlayerMap(Index) = GetPlayerMap(i) Then
            Armor = 0
            Helmet = 0
            Shield = 0
            Weapon = 0
        End If
        If GetPlayerArmorSlot(i) > 0 Then
            Armor = GetPlayerInvItemNum(i, GetPlayerArmorSlot(i))
        End If
        If GetPlayerHelmetSlot(i) > 0 Then
            Helmet = GetPlayerInvItemNum(i, GetPlayerHelmetSlot(i))
        End If
        If GetPlayerShieldSlot(i) > 0 Then
            Shield = GetPlayerInvItemNum(i, GetPlayerShieldSlot(i))
        End If
        If GetPlayerWeaponSlot(i) > 0 Then
            Weapon = GetPlayerInvItemNum(i, GetPlayerWeaponSlot(i))
        End If
        Packet = "itemworn" & SEP_CHAR & i & SEP_CHAR & Armor & SEP_CHAR & Weapon & SEP_CHAR & Helmet & SEP_CHAR & Shield & SEP_CHAR & END_CHAR
        Call SendDataTo(Index, Packet)
    End If
Next i
End Sub

pingu Wrote:1. Indent that whole For loop one time. It's much easier to tell where a sub or function starts and ends if the start and end are the only lines that are on the far left side. The next doesn't effect that too much in this example, but any other code not in one of those statements would ruin the effect more.

2. "If IsPlaying(i) Then" looks so much nicer than adding a "= true" and they do the same thing. It's always best to make it logical, so that you can read it out like a sentence. "If this guy is playing then" makes more sense than "If this guy is playing and that is true, then". It's better for variables like "InEditor", because it makes so much more sense. "Do While NotDone" is my favorite...

Misunderstood Wrote:Ohh and another thing to bully/pester you about!

I know in this case you might not have known that the packet line would wrap to the next line, but when in the vb ide you have something wrap to the next line, make the 2nd line indented atleast 1 from the first like

sooo:

Code:

Packet="blah" & sep_char & "stupid" &
    sep_char & end_char

pingu Wrote:I've never tried it, but don't you need a "_" at the end of a line to signal that it continues on the next line?

Dark Echo Wrote:

pingu Wrote:I've never tried it, but don't you need a "_" at the end of a line to signal that it continues on the next line?

Actually dude.. You do need an underscore.. In visual basics it means the line of code has been divided onto another line..