+- Mirage Engine (https://mirage-engine.uk/forums)
+-- Forum: Mirage Source (Nostalgia) (https://mirage-engine.uk/forums/forumdisplay.php?fid=61)
+--- Forum: Archive (2006-2011) (https://mirage-engine.uk/forums/forumdisplay.php?fid=18)
+---- Forum: Source Code Development (https://mirage-engine.uk/forums/forumdisplay.php?fid=51)
+----- Forum: Mirage Source 4 (Visual Basic 6) (https://mirage-engine.uk/forums/forumdisplay.php?fid=44)
+----- Thread: Redundant...? (/showthread.php?tid=2241)
Redundant...? - Nean - 14-10-2008
Okay, so I was scrolling through the code in the server, and I found this:
Code:
Private Sub mnuKickPlayer_Click()
Dim Name As String
Name = frmServer.lvwInfo.SelectedItem.SubItems(3)
If Not Name = "Not Playing" Then
Call AlertMsg(FindPlayer(Name), "You have been kicked by the server owner!")
CloseSocket (FindPlayer(Name))
End If
End SubHowever the specific code in question is:
Code:
Call AlertMsg(FindPlayer(Name), "You have been kicked by the server owner!")
CloseSocket (FindPlayer(Name))As you can see, it calls an Alert, but then it also calls a CloseSocket. However, AlertMsg, calls close socket, so wouldn't that be redundant? I'm sure even if it is redundant, it isn't doing much to slow down the game, or if at all. Just wondering.
Re: Redundant...? - Nean - 14-10-2008
Yeah, I was just wondering. I'm sorta surprised I spotted that, I feel so special now.
Re: Redundant...? - Nean - 14-10-2008
DFA Wrote:shouldnt be surprised :-)
mirage source is one of the shittiest source codes in the history of programming, thats why its so easy to update and improve, and it explains the massive changelog.
Yes, but I'm one of the shittiest programmers in the history of programming, that's why I fail so hard to fix stuff, and add new features.
Re: Redundant...? - GIAKEN - 14-10-2008
Nean Wrote:DFA Wrote:shouldnt be surprised :-)
mirage source is one of the shittiest source codes in the history of programming, thats why its so easy to update and improve, and it explains the massive changelog.
Yes, but I'm one of the shittiest programmers in the history of programming, that's why I fail so hard to fix stuff, and add new features.
Everybody is the shittiest programmer when they first start.